Reimplement MappedList using a backigList #3069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusDietz
added
the
status: ready-for-review
Member
|
Could you add a test to ensure correct behaviour? |
tobiasdiez
approved these changes
Aug 2, 2017
Member
tobiasdiez
left a comment
tobiasdiez
left a comment
There was a problem hiding this comment.
The code looks good to me, but I didn't test if the group interface still work as expected.
Member
Author
|
@Siedlerchr actually the test coverage covers the important parts of the method. |
Member
Author
|
@tobiasdiez I manually tested it, however I don't have many groups. Please check that. |
Siedlerchr
added a commit
that referenced
this pull request
Aug 6, 2017
* upstream/master: Add warning message if group with same name is already present (#3077) Fix #3062: Ctrl + F works again Fix del/copy/paste key trigger main table action in search bar (#3070) Fix markdown Update gradle from 4.0.1 to 4.0.2 Fix #3045 Update Transformer plugin Reimplement MappedList using a backigList (#3069) Fix importing preferences after resetting without restarting (#3065) Fix some spotbugs issues (#3060) Import dialog when fetch (#3025) Adapt CircleCI build Adapt CI script Closes #3027 and updates install4j to v7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the followup for #3032 (comment).
This is different from #3032, as now the mapping only happens on insert.