Skip to content

Conversation

@tobiasdiez
Copy link
Member

Fixes #2471 by removing all new line characters from the abstracts.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 11, 2017
@tobiasdiez tobiasdiez closed this Oct 11, 2017
@tobiasdiez tobiasdiez reopened this Oct 11, 2017
@tobiasdiez
Copy link
Member Author

Thanks @Siedlerchr for fixing the build! Its really not fun to "program" with the github editor. Seems like I need to find a new way to procrastinate :-)

@tobiasdiez tobiasdiez merged commit ef7f824 into master Oct 12, 2017
@tobiasdiez tobiasdiez deleted the improveADSNewlines branch October 12, 2017 02:53
Siedlerchr added a commit that referenced this pull request Oct 19, 2017
* upstream/master:
  Update gradle to 4.2.1 (#3322)
  Avoid recreation of the EntryEditor (#3187)
  Fix #3133 telemetry by locking azure to 1.0.9
  German translation for missing properties (#3312)
  Improvement for Java FX font rendering on Linux (#3305)
  Add also conversion for em dash
  Add \textendash to the html conversion table
  Update latex2tunicode from 0.2.1 -> 0.2.2
  Added note about updating controlsfx
  Fix exception/freezing on EntryChangedEvent in Entry Editor (#3299)
  Update libs (#3300)
  update guava from 23.0 -> 23.2
  update mvvmfx-validation from 1.6.0 -> 1.7.0
  Resolves #3255 file open dialog should have "supported formates" filetype
  Fix #3235: remote metadata is updated instead of delete + insert (#3282)
  Change OO paths to Libre Office in preferences (#3287)
  Fix #2471: remove line breaks from abstracts in ADS fetcher (#3285)
  Resolves #3280 Empty String instead of N/A (#3288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants