Skip to content

Conversation

@tobiasdiez
Copy link
Member

In order to help @Siedlerchr, I fixed a bug in the framework which we use to inject dependencies in the javafx controller. I proposed a PR AdamBien/afterburner.fx#80 but as he is a bit slow with integrating fixes, I think we should directly include the fix in JabRef for the moment (and remove it as soon as a new version of afterburner.fx with the fix is released).

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 22, 2017
@tobiasdiez tobiasdiez mentioned this pull request Oct 22, 2017
6 tasks
@Siedlerchr
Copy link
Member

Siedlerchr commented Oct 22, 2017

Why don't we create a fork of the original project and include other fixes as well, e.g. the system errr output (there is already a Pr regarding that)
@JabRef/developers WDYT about this, forking the original code and maintaining it

@lenhard
Copy link
Member

lenhard commented Nov 7, 2017

The problem here is the license. We cannot just copy the code and use it here, because it is licensed differently. We will need to go for a fork / separate library.

@koppor will contact the author of afterburner per mail. Maybe this wakes him up.

@tobiasdiez
Copy link
Member Author

I really like license problems :-). I would actually help Adam Bien to maintain this library. I think, of now JabRef is one of the main users of afterburner and thus we should be interested in having a stable and working platform. (I don't like a separate fork).

@tobiasdiez tobiasdiez closed this Nov 8, 2017
@tobiasdiez tobiasdiez deleted the fixInjector branch November 8, 2017 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[outdated] type: question status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants