Skip to content

Conversation

@koppor
Copy link
Member

@koppor koppor commented Mar 31, 2018

While working on #3704, test were failing in other settings. This is a quick fix to get the tests running.

@koppor koppor mentioned this pull request Mar 31, 2018
8 tasks
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do a proper refactoring and remove the Globals.prefs dependency from LinkedFileViewModel.

@Siedlerchr
Copy link
Member

I think for this build it's okay, in maintable-beta we already have it refactored

@koppor
Copy link
Member Author

koppor commented Apr 1, 2018

@Siedlerchr I hope, there won't be conflicts for the maintable-beta branch then. 😇

@koppor koppor merged commit 7bd7eda into master Apr 1, 2018
@koppor koppor deleted the add-mock branch April 1, 2018 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants