Skip to content

Improve toolbar icons and their layout #4730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 8, 2019
Merged

Improve toolbar icons and their layout #4730

merged 5 commits into from
Mar 8, 2019
+13 −11

Conversation

@yurickyh
Copy link
Contributor

@yurickyh yurickyh commented Mar 6, 2019

Group and reorder the toolbar icons and add 'Generate BibTeX keys' button. Now it looks like on the @MartinKarim's prototypes.

Screenshots of the new layout:
right
left

This PR fixes #4584 .

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

yurickyh and others added 5 commits March 4, 2019 12:37
@yurickyh
Merge pull request #1 from JabRef/master
3cc3cf8 
Syncing your fork to the original repository
@yurickyh
Merge pull request #2 from JabRef/master
4161756 
Syncing this fork to the original repository.
@kaiquekk @yurickyh
Change toolbar icons and add separators
a1858cb 
Changed some toolbar icons and grouped them visually with vertical
separators.

Signed-off-by: kaiquekk <[email protected]>
@yurickyh
Adding GENERATE_CITE_KEYS button to toolbar.
d157b9d 
Signed-off-by: yurickyh <[email protected]>
@kaiquekk
Add changes to CHANGELOG and fix New Library icons
5025d0b 
Signed-off-by: kaiquekk <[email protected]>
@yurickyh yurickyh changed the title Improve toolbar icons and their layout #4584 Improve toolbar icons and their layout Mar 6, 2019
@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 8, 2019
tobiasdiez
tobiasdiez approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Looks good to me!

@Siedlerchr Siedlerchr merged commit 75b7517 into JabRef:master Mar 8, 2019
github-actions bot pushed a commit that referenced this pull request Apr 30, 2020
Squashed 'src/main/resources/csl-styles/' changes from 143464e..906cd6d
86550b3 
906cd6d Create technische-universitat-dresden-linguistik-author-date (#4730)
607a056 Create ifao-publications.csl (#4731)
5a65f50 remove et-al settings for bibliography for PVS (#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (#4734)
d70c2a4 Add chapter section in bibliography (#4732)
366dbc1 Create economic-history-review.csl (#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (#4729)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from c1793d2..906cd6d
366f3b0 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to calixtus/jabref that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from c1793d2..906cd6d
34d37f0 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to eetian/jabref that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from c1793d2..906cd6d
c828159 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to leitianjian/jabref that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 06785fa..906cd6d
19d2d5c 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to abepolk/jabref that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from c1793d2..906cd6d
1bc990d 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from c1793d2..906cd6d
67a38d3 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to dextep/jabref that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from 143464e..906cd6d
2a00aa3 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to ShikunXiong/jabref that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from c1793d2..906cd6d
b3948d3 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
github-actions bot pushed a commit to systemoperator/jabref that referenced this pull request May 1, 2020
Squashed 'src/main/resources/csl-styles/' changes from c1793d2..906cd6d
635651b 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)
143464e Fix comma before et al. for the-oncologist.csl (JabRef#4724)
3b331b6 fixed bug with "near-note" position univ.-bordeaux-ecole-doctorale-de… (JabRef#4719)
b2c0c1e APA: in-text title in title-case (JabRef#4725)
88c68d2 Fix et-al and indetation settings for mammalia.csl (JabRef#4717)
05940a2 Update the-febs-journal.csl (JabRef#4720)
1d77ba8 Request for review and assessment of the repa.csl (JabRef#4698)
76b4be5 Update isnad.csl (JabRef#4716)
f709c84 Update isnad-dipnotlu.csl (JabRef#4715)
45d7655 Create mammalia.csl (JabRef#4714)
eb333ca Update society-for-american-archaeology.csl (JabRef#4710)
d944e71 Update masarykova-univerzita-pravnicka-fakulta.csl (JabRef#4712)
5e34eb1 Update animal-welfare.csl (JabRef#4713)
06785fa Update le-tapuscrit-author-date.csl (JabRef#4708)
ada5282 Update norois.csl (JabRef#4707)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
dextep pushed a commit to dextep/jabref that referenced this pull request May 8, 2020
@dextep
Squashed 'src/main/resources/csl-styles/' changes from 143464e..906cd6d
0a6ac4d 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
dextep pushed a commit to dextep/jabref that referenced this pull request May 8, 2020
@dextep
Squashed 'src/main/resources/csl-styles/' changes from 143464e..906cd6d
d68d044 
906cd6d Create technische-universitat-dresden-linguistik-author-date (JabRef#4730)
607a056 Create ifao-publications.csl (JabRef#4731)
5a65f50 remove et-al settings for bibliography for PVS (JabRef#4735)
4a145d4 Create current-opinion-in-endocrinology-diabetes-and-obesity.csl (JabRef#4734)
d70c2a4 Add chapter section in bibliography (JabRef#4732)
366dbc1 Create economic-history-review.csl (JabRef#4643)
7069ddc Create the-open-university-harvard-s390-modules.csl (JabRef#4711)
a789973 Chicago: Uppercase "Presentated at" if no `genre` (JabRef#4729)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 906cd6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Toolbar icons and their layout need improvement

4 participants

@yurickyh @Siedlerchr @tobiasdiez @kaiquekk