Skip to content

Allow hyphens in bibtexgenygenerator #4768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Allow hyphens in bibtexgenygenerator #4768

wants to merge 2 commits into from

Conversation

@Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Mar 17, 2019 •
edited
Loading

Add Test
Fixes #4767

Hyphens are legal characters and should be allowed.
Only drawback authors with hyphens in the name e.g. Al-Ketan and using a pattern like [auth3] are reduced to Al-`

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 17, 2019
@Siedlerchr Siedlerchr closed this Mar 18, 2019
@Siedlerchr
Copy link
Member Author

superseeded by #4770

@Siedlerchr Siedlerchr deleted the fixhypheninbibtexkeygenerator branch March 18, 2019 07:52
github-actions bot pushed a commit to leitianjian/jabref that referenced this pull request May 7, 2020
Squashed 'src/main/resources/csl-styles/' changes from 906cd6d..270cd32
71e185d 
270cd32 small fixes for revista-biblica.csl (JabRef#4770)
5dd7ede fix issue with DOI URL for unified-style-sheet-for-linguistics.csl (JabRef#4765)
9556b12 Create the-american-journal-of-bioethics.csl (JabRef#4766)
d50c761 fix initials of revista-biblica.csl (JabRef#4768)
acbb043 Create nwu-harvard-2020.csl (JabRef#4762)
cb19d25 Create revista-biblica.csl (JabRef#4763)
d40b5ff Small corrections in IFAO style (JabRef#4761)
ba4dd7c Add NZ Journal of History (JabRef#4760)
1e20dbd Harvard Stellenbosch: Further et al adjustment
a59a17e Update american-medical-association.csl to version 11 (JabRef#4727)
22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (JabRef#4627)
647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (JabRef#4756)
a4317f2 Update quaternaire.csl (JabRef#4752)
36fe9c2 Update journal-of-management-studies.csl (JabRef#4740)
f0cb15d Bugfix (JabRef#4750)
ef19002 Revert 1 yrg23 patch 1 (JabRef#4754)
873fc9e Update the-geological-society-of-london.csl (JabRef#4738)
93ca354 Update The Geological Society dependents (JabRef#4751)
9d3f0f5 Update technische-universitat-dresden-linguistik.csl (JabRef#4737)
63d657c change et al. min (JabRef#4736)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 270cd32
github-actions bot pushed a commit that referenced this pull request May 7, 2020
Squashed 'src/main/resources/csl-styles/' changes from 906cd6d..270cd32
5c1e88e 
270cd32 small fixes for revista-biblica.csl (#4770)
5dd7ede fix issue with DOI URL for unified-style-sheet-for-linguistics.csl (#4765)
9556b12 Create the-american-journal-of-bioethics.csl (#4766)
d50c761 fix initials of revista-biblica.csl (#4768)
acbb043 Create nwu-harvard-2020.csl (#4762)
cb19d25 Create revista-biblica.csl (#4763)
d40b5ff Small corrections in IFAO style (#4761)
ba4dd7c Add NZ Journal of History (#4760)
1e20dbd Harvard Stellenbosch: Further et al adjustment
a59a17e Update american-medical-association.csl to version 11 (#4727)
22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (#4627)
647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (#4756)
a4317f2 Update quaternaire.csl (#4752)
36fe9c2 Update journal-of-management-studies.csl (#4740)
f0cb15d Bugfix (#4750)
ef19002 Revert 1 yrg23 patch 1 (#4754)
873fc9e Update the-geological-society-of-london.csl (#4738)
93ca354 Update The Geological Society dependents (#4751)
9d3f0f5 Update technische-universitat-dresden-linguistik.csl (#4737)
63d657c change et al. min (#4736)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 270cd32
github-actions bot pushed a commit to dextep/jabref that referenced this pull request May 8, 2020
Squashed 'src/main/resources/csl-styles/' changes from 1e20dbd..c35d219
e410fbb 
c35d219 Create journal-of-the-royal-society-of-western-australia.csl (JabRef#4772)
e772607 Update journal-of-the-royal-society-of-western-australia.csl
c4b5edc Update journal-of-the-royal-society-of-western-australia.csl
2245fb1 Update journal-of-the-royal-society-of-western-australia.csl
e8bcb31 Create journal-of-the-royal-society-of-western-australia.csl
270cd32 small fixes for revista-biblica.csl (JabRef#4770)
5dd7ede fix issue with DOI URL for unified-style-sheet-for-linguistics.csl (JabRef#4765)
9556b12 Create the-american-journal-of-bioethics.csl (JabRef#4766)
d50c761 fix initials of revista-biblica.csl (JabRef#4768)
acbb043 Create nwu-harvard-2020.csl (JabRef#4762)
cb19d25 Create revista-biblica.csl (JabRef#4763)
d40b5ff Small corrections in IFAO style (JabRef#4761)
ba4dd7c Add NZ Journal of History (JabRef#4760)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: c35d219
github-actions bot pushed a commit to ShikunXiong/jabref that referenced this pull request May 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 906cd6d..586e0b8
07f1ae0 
586e0b8 Reindent/reorder
56cd2cb small fixes for skene-journal-of-theatre-and-drama-studies.csl (JabRef#4779)
31ab72f fix demote-non-dropping-particle for equine-veterinary-education.csl (JabRef#4778)
93d409f Create skene-journal-of-theatre-and-drama-studies.csl (JabRef#4776)
06ab6ec Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4777)
3b27a45 Create archaeonautica.csl (JabRef#4775)
0e0acb7 Create antafr.csl (JabRef#4774)
5dad23d Create monash-university-csiro.csl (JabRef#4773)
c35d219 Create journal-of-the-royal-society-of-western-australia.csl (JabRef#4772)
e772607 Update journal-of-the-royal-society-of-western-australia.csl
c4b5edc Update journal-of-the-royal-society-of-western-australia.csl
2245fb1 Update journal-of-the-royal-society-of-western-australia.csl
e8bcb31 Create journal-of-the-royal-society-of-western-australia.csl
270cd32 small fixes for revista-biblica.csl (JabRef#4770)
5dd7ede fix issue with DOI URL for unified-style-sheet-for-linguistics.csl (JabRef#4765)
9556b12 Create the-american-journal-of-bioethics.csl (JabRef#4766)
d50c761 fix initials of revista-biblica.csl (JabRef#4768)
acbb043 Create nwu-harvard-2020.csl (JabRef#4762)
cb19d25 Create revista-biblica.csl (JabRef#4763)
d40b5ff Small corrections in IFAO style (JabRef#4761)
ba4dd7c Add NZ Journal of History (JabRef#4760)
1e20dbd Harvard Stellenbosch: Further et al adjustment
a59a17e Update american-medical-association.csl to version 11 (JabRef#4727)
22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (JabRef#4627)
647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (JabRef#4756)
a4317f2 Update quaternaire.csl (JabRef#4752)
36fe9c2 Update journal-of-management-studies.csl (JabRef#4740)
f0cb15d Bugfix (JabRef#4750)
ef19002 Revert 1 yrg23 patch 1 (JabRef#4754)
873fc9e Update the-geological-society-of-london.csl (JabRef#4738)
93ca354 Update The Geological Society dependents (JabRef#4751)
9d3f0f5 Update technische-universitat-dresden-linguistik.csl (JabRef#4737)
63d657c change et al. min (JabRef#4736)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 586e0b8
github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this pull request May 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 906cd6d..586e0b8
6e5c1ab 
586e0b8 Reindent/reorder
56cd2cb small fixes for skene-journal-of-theatre-and-drama-studies.csl (JabRef#4779)
31ab72f fix demote-non-dropping-particle for equine-veterinary-education.csl (JabRef#4778)
93d409f Create skene-journal-of-theatre-and-drama-studies.csl (JabRef#4776)
06ab6ec Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4777)
3b27a45 Create archaeonautica.csl (JabRef#4775)
0e0acb7 Create antafr.csl (JabRef#4774)
5dad23d Create monash-university-csiro.csl (JabRef#4773)
c35d219 Create journal-of-the-royal-society-of-western-australia.csl (JabRef#4772)
e772607 Update journal-of-the-royal-society-of-western-australia.csl
c4b5edc Update journal-of-the-royal-society-of-western-australia.csl
2245fb1 Update journal-of-the-royal-society-of-western-australia.csl
e8bcb31 Create journal-of-the-royal-society-of-western-australia.csl
270cd32 small fixes for revista-biblica.csl (JabRef#4770)
5dd7ede fix issue with DOI URL for unified-style-sheet-for-linguistics.csl (JabRef#4765)
9556b12 Create the-american-journal-of-bioethics.csl (JabRef#4766)
d50c761 fix initials of revista-biblica.csl (JabRef#4768)
acbb043 Create nwu-harvard-2020.csl (JabRef#4762)
cb19d25 Create revista-biblica.csl (JabRef#4763)
d40b5ff Small corrections in IFAO style (JabRef#4761)
ba4dd7c Add NZ Journal of History (JabRef#4760)
1e20dbd Harvard Stellenbosch: Further et al adjustment
a59a17e Update american-medical-association.csl to version 11 (JabRef#4727)
22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (JabRef#4627)
647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (JabRef#4756)
a4317f2 Update quaternaire.csl (JabRef#4752)
36fe9c2 Update journal-of-management-studies.csl (JabRef#4740)
f0cb15d Bugfix (JabRef#4750)
ef19002 Revert 1 yrg23 patch 1 (JabRef#4754)
873fc9e Update the-geological-society-of-london.csl (JabRef#4738)
93ca354 Update The Geological Society dependents (JabRef#4751)
9d3f0f5 Update technische-universitat-dresden-linguistik.csl (JabRef#4737)
63d657c change et al. min (JabRef#4736)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 586e0b8
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this pull request May 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 906cd6d..586e0b8
9de9a2e 
586e0b8 Reindent/reorder
56cd2cb small fixes for skene-journal-of-theatre-and-drama-studies.csl (JabRef#4779)
31ab72f fix demote-non-dropping-particle for equine-veterinary-education.csl (JabRef#4778)
93d409f Create skene-journal-of-theatre-and-drama-studies.csl (JabRef#4776)
06ab6ec Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4777)
3b27a45 Create archaeonautica.csl (JabRef#4775)
0e0acb7 Create antafr.csl (JabRef#4774)
5dad23d Create monash-university-csiro.csl (JabRef#4773)
c35d219 Create journal-of-the-royal-society-of-western-australia.csl (JabRef#4772)
e772607 Update journal-of-the-royal-society-of-western-australia.csl
c4b5edc Update journal-of-the-royal-society-of-western-australia.csl
2245fb1 Update journal-of-the-royal-society-of-western-australia.csl
e8bcb31 Create journal-of-the-royal-society-of-western-australia.csl
270cd32 small fixes for revista-biblica.csl (JabRef#4770)
5dd7ede fix issue with DOI URL for unified-style-sheet-for-linguistics.csl (JabRef#4765)
9556b12 Create the-american-journal-of-bioethics.csl (JabRef#4766)
d50c761 fix initials of revista-biblica.csl (JabRef#4768)
acbb043 Create nwu-harvard-2020.csl (JabRef#4762)
cb19d25 Create revista-biblica.csl (JabRef#4763)
d40b5ff Small corrections in IFAO style (JabRef#4761)
ba4dd7c Add NZ Journal of History (JabRef#4760)
1e20dbd Harvard Stellenbosch: Further et al adjustment
a59a17e Update american-medical-association.csl to version 11 (JabRef#4727)
22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (JabRef#4627)
647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (JabRef#4756)
a4317f2 Update quaternaire.csl (JabRef#4752)
36fe9c2 Update journal-of-management-studies.csl (JabRef#4740)
f0cb15d Bugfix (JabRef#4750)
ef19002 Revert 1 yrg23 patch 1 (JabRef#4754)
873fc9e Update the-geological-society-of-london.csl (JabRef#4738)
93ca354 Update The Geological Society dependents (JabRef#4751)
9d3f0f5 Update technische-universitat-dresden-linguistik.csl (JabRef#4737)
63d657c change et al. min (JabRef#4736)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 586e0b8
github-actions bot pushed a commit to eetian/jabref that referenced this pull request May 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 906cd6d..586e0b8
73e6295 
586e0b8 Reindent/reorder
56cd2cb small fixes for skene-journal-of-theatre-and-drama-studies.csl (JabRef#4779)
31ab72f fix demote-non-dropping-particle for equine-veterinary-education.csl (JabRef#4778)
93d409f Create skene-journal-of-theatre-and-drama-studies.csl (JabRef#4776)
06ab6ec Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4777)
3b27a45 Create archaeonautica.csl (JabRef#4775)
0e0acb7 Create antafr.csl (JabRef#4774)
5dad23d Create monash-university-csiro.csl (JabRef#4773)
c35d219 Create journal-of-the-royal-society-of-western-australia.csl (JabRef#4772)
e772607 Update journal-of-the-royal-society-of-western-australia.csl
c4b5edc Update journal-of-the-royal-society-of-western-australia.csl
2245fb1 Update journal-of-the-royal-society-of-western-australia.csl
e8bcb31 Create journal-of-the-royal-society-of-western-australia.csl
270cd32 small fixes for revista-biblica.csl (JabRef#4770)
5dd7ede fix issue with DOI URL for unified-style-sheet-for-linguistics.csl (JabRef#4765)
9556b12 Create the-american-journal-of-bioethics.csl (JabRef#4766)
d50c761 fix initials of revista-biblica.csl (JabRef#4768)
acbb043 Create nwu-harvard-2020.csl (JabRef#4762)
cb19d25 Create revista-biblica.csl (JabRef#4763)
d40b5ff Small corrections in IFAO style (JabRef#4761)
ba4dd7c Add NZ Journal of History (JabRef#4760)
1e20dbd Harvard Stellenbosch: Further et al adjustment
a59a17e Update american-medical-association.csl to version 11 (JabRef#4727)
22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (JabRef#4627)
647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (JabRef#4756)
a4317f2 Update quaternaire.csl (JabRef#4752)
36fe9c2 Update journal-of-management-studies.csl (JabRef#4740)
f0cb15d Bugfix (JabRef#4750)
ef19002 Revert 1 yrg23 patch 1 (JabRef#4754)
873fc9e Update the-geological-society-of-london.csl (JabRef#4738)
93ca354 Update The Geological Society dependents (JabRef#4751)
9d3f0f5 Update technische-universitat-dresden-linguistik.csl (JabRef#4737)
63d657c change et al. min (JabRef#4736)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 586e0b8
github-actions bot pushed a commit to dextep/jabref that referenced this pull request May 15, 2020
Squashed 'src/main/resources/csl-styles/' changes from 906cd6d..586e0b8
2a40128 
586e0b8 Reindent/reorder
56cd2cb small fixes for skene-journal-of-theatre-and-drama-studies.csl (JabRef#4779)
31ab72f fix demote-non-dropping-particle for equine-veterinary-education.csl (JabRef#4778)
93d409f Create skene-journal-of-theatre-and-drama-studies.csl (JabRef#4776)
06ab6ec Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4777)
3b27a45 Create archaeonautica.csl (JabRef#4775)
0e0acb7 Create antafr.csl (JabRef#4774)
5dad23d Create monash-university-csiro.csl (JabRef#4773)
c35d219 Create journal-of-the-royal-society-of-western-australia.csl (JabRef#4772)
e772607 Update journal-of-the-royal-society-of-western-australia.csl
c4b5edc Update journal-of-the-royal-society-of-western-australia.csl
2245fb1 Update journal-of-the-royal-society-of-western-australia.csl
e8bcb31 Create journal-of-the-royal-society-of-western-australia.csl
270cd32 small fixes for revista-biblica.csl (JabRef#4770)
5dd7ede fix issue with DOI URL for unified-style-sheet-for-linguistics.csl (JabRef#4765)
9556b12 Create the-american-journal-of-bioethics.csl (JabRef#4766)
d50c761 fix initials of revista-biblica.csl (JabRef#4768)
acbb043 Create nwu-harvard-2020.csl (JabRef#4762)
cb19d25 Create revista-biblica.csl (JabRef#4763)
d40b5ff Small corrections in IFAO style (JabRef#4761)
ba4dd7c Add NZ Journal of History (JabRef#4760)
1e20dbd Harvard Stellenbosch: Further et al adjustment
a59a17e Update american-medical-association.csl to version 11 (JabRef#4727)
22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (JabRef#4627)
647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (JabRef#4756)
a4317f2 Update quaternaire.csl (JabRef#4752)
36fe9c2 Update journal-of-management-studies.csl (JabRef#4740)
f0cb15d Bugfix (JabRef#4750)
ef19002 Revert 1 yrg23 patch 1 (JabRef#4754)
873fc9e Update the-geological-society-of-london.csl (JabRef#4738)
93ca354 Update The Geological Society dependents (JabRef#4751)
9d3f0f5 Update technische-universitat-dresden-linguistik.csl (JabRef#4737)
63d657c change et al. min (JabRef#4736)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 586e0b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Siedlerchr