Skip to content

Conversation

@adamrehn
Copy link
Contributor

Adds a new menu option called "Save selected as plain BibTeX ...".

This option behaves the same way as the existing "Save selected as ..." option, except that the JabRef metadata and signature comment are not written to the resulting output file.

Adds a new menu option called "Save selected as plain BibTeX ...".

This option behaves the same way as the existing "Save selected as ..." option, except that the JabRef metadata and signature comment are not written to the resulting output file.
@simonharrer
Copy link
Contributor

Thank you for your pull request. The feature is interesting.

I would suggest to improve code quality a little bit by applying one of suggestions of the Item 40: Design method signatures carefully of the Effective Java book: Prefer two-element enum types to boolean parameters

Instead of a boolean that determines whether or not plain BibTeX is exported, an enum is now used that differentiates between the default and plain export options.

The use of an enum provides flexibility that facilitates the addition of further format customisation options in the future.
@adamrehn
Copy link
Contributor Author

@simonharrer That's an excellent suggestion. The use of an enum facilitates easily adding further export customisations in future, if desired. I've updated the code accordingly.

@simonharrer
Copy link
Contributor

Can you add yourself to the list of Contributors according to the https://github.com/JabRef/jabref/blob/master/CONTRIBUTING.md file, please, to give you credit for submitting this patch.

@adamrehn
Copy link
Contributor Author

My name has already been added to the contributors list in a previous commit.

@simonharrer
Copy link
Contributor

Ok, then thank you again for this pull request.

simonharrer added a commit that referenced this pull request May 19, 2015
Add the option to save selected entries as plain BibTeX.
@simonharrer simonharrer merged commit 2feef98 into JabRef:master May 19, 2015
@adamrehn adamrehn deleted the exportplain branch May 20, 2015 05:02
InAnYan added a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants