Skip to content

"Set up general fields" character check not correct & alphabetical ordering #5034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 7, 2019
Merged

"Set up general fields" character check not correct & alphabetical ordering #5034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c612072
Change TreeMap for LinkedHashMap on create function.
yurickyh Jun 5, 2019
d78997c
Remove the character '-' on KEY_ILLEGAL_CHARACTERS and KEY_UNWANTED_C…
yurickyh Jun 5, 2019
ad6e549
Add changes in CHANGELOG.
kaiquekk Jun 5, 2019
c527f71
Fix checkstyle error.
kaiquekk Jun 5, 2019
57782e4
Remove option to name a field with hyphen.
kaiquekk Jun 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
- We added an option on the Linked File Viewer to rename the attached file of an entry directly on the JabRef. [#4844](https://github.com/JabRef/jabref/issues/4844)
- We added an option in the preference dialog box that allows user to enable helpful tooltips.[#3599](https://github.com/JabRef/jabref/issues/3599)
- We moved the dropdown menu for selecting the push-application from the toolbar into the external application preferences. [#674](https://github.com/JabRef/jabref/issues/674)
- We removed the alphabetical ordering of the custom tabs and updated the error message when trying to create a general field with a name containing an illegal character. [#5019](https://github.com/JabRef/jabref/issues/5019)


### Fixed
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/gui/customizefields/CustomizeGeneralFieldsDialogViewModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public void saveFields() {
String title = Localization.lang("Error");
String content = Localization.lang("Field names are not allowed to contain white space or the following "
+ "characters")
+ ": # { } ~ , ^ &";
+ ": # { } ( ) ~ , ^ & - \" ' ` ʹ \\";
dialogService.showInformationDialogAndWait(title, content);
return;
}
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/jabref/gui/entryeditor/EntryEditorTabList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package org.jabref.gui.entryeditor;

import java.util.Arrays;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.TreeMap;

import org.jabref.preferences.JabRefPreferences;

Expand All @@ -17,7 +17,7 @@ private EntryEditorTabList() {
}

public static Map<String, List<String>> create(JabRefPreferences preferences) {
Map<String, List<String>> tabs = new TreeMap<>();
Map<String, List<String>> tabs = new LinkedHashMap<>();
int i = 0;
String name;
if (preferences.hasKey(JabRefPreferences.CUSTOM_TAB_NAME + 0)) {
Expand Down