Use UTF-8 as default encoding for files #5213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-kolb
added
the
status: ready-for-review
stefan-kolb
changed the title
If we create journal abbrev files via the JabRef, they are saved in UTF-8. So it makes sense to use this as default encoding. Also see #5133.
stefan-kolb
force-pushed
the
journal-abbrev-encoding
branch
from
6b6f68a to
f04a26e
Compare
LinusDietz
approved these changes
Aug 24, 2019
Co-authored-by: Linus Dietz <[email protected]>
This reverts commit 19f0d85.
Siedlerchr
added a commit
that referenced
this pull request
Aug 24, 2019
* upstream/master: fix bug where main file directory is not set correctly (#5215) Use UTF-8 as default encoding for files (#5213) fix: missing separator for unchanged diff words fix: use UTF-8 as default encoding for files ~ resolves #5133 Minor improvements to TexParser Fix lookup entry types in enums (#5209)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we create journal abbrev files via the JabRef, they are saved in UTF-8.
So it makes sense to use this as default encoding. Also see #5133.