Skip to content

Conversation

@calixtus
Copy link
Member

Fixes bug in #5451
Should be pretty self-explanatory.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@calixtus
Copy link
Member Author

Is it intended, that the preview still shows up in the requiredFieldsTab?

@Siedlerchr
Copy link
Member

I thought the same. It should be an either or

@tobiasdiez
Copy link
Member

That's happening if you make last-minute changes without double checking these changes. Thanks!

And no, the entry preview should show either as a tab or in split pane. For me that worked.

@tobiasdiez tobiasdiez merged commit e81d58c into JabRef:master Oct 17, 2019
@calixtus calixtus deleted the fix-preview-fxml branch October 17, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants