Skip to content

Fix not on fx thread error for custom entry types #5483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2019
Merged

Fix not on fx thread error for custom entry types #5483

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
269a786
Fix not on fx thread error for custom entry types
Siedlerchr Oct 19, 2019
cbaf5ea
Merge remote-tracking branch 'upstream/master' into fixnotonfxthread
Siedlerchr Oct 21, 2019
37d4ca1
Use Platform.runLater
Siedlerchr Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/main/java/org/jabref/JabRefGUI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import java.util.Iterator;
import java.util.List;

import javafx.application.Platform;
import javafx.scene.Scene;
import javafx.stage.Stage;

Expand Down Expand Up @@ -41,12 +42,10 @@ public class JabRefGUI {
private final boolean isBlank;
private final List<ParserResult> failed = new ArrayList<>();
private final List<ParserResult> toOpenTab = new ArrayList<>();
private final JabRefExecutorService executorService;

public JabRefGUI(Stage mainStage, List<ParserResult> databases, boolean isBlank) {
this.bibDatabases = databases;
this.isBlank = isBlank;
executorService = JabRefExecutorService.INSTANCE;
mainFrame = new JabRefFrame(mainStage);

openWindow(mainStage);
Expand Down Expand Up @@ -89,8 +88,7 @@ private void openWindow(Stage mainStage) {
event.consume();
}
});

executorService.execute(this::openDatabases);
Platform.runLater(this::openDatabases);
}

private void openDatabases() {
Expand Down Expand Up @@ -176,6 +174,7 @@ private void openDatabases() {
for (int i = 0; (i < bibDatabases.size()) && (i < mainFrame.getBasePanelCount()); i++) {
ParserResult pr = bibDatabases.get(i);
BasePanel panel = mainFrame.getBasePanelAt(i);

OpenDatabaseAction.performPostOpenActions(panel, pr);
}

Expand Down