Fix 5555 status popups #5560
Merged
Fix 5555 status popups #5560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ka0o0
force-pushed
the
fix-5555-status-popups
branch
from
fc6ca01 to
1721eda
Compare
koppor
reviewed
Nov 3, 2019
koppor
requested changes
Nov 3, 2019
Member
koppor
left a comment
koppor
left a comment
There was a problem hiding this comment.
In general: Looks good to me. I wondered about the noisy notifications. - Some small comment on the usage of boolean remains
tobiasdiez
approved these changes
Nov 3, 2019
Member
tobiasdiez
left a comment
tobiasdiez
left a comment
There was a problem hiding this comment.
Nice to see another good PR from you in such a short time!
Siedlerchr
approved these changes
Nov 6, 2019
Member
|
@Ka0o0 Thanks for your contribution again! Could you please fix the checkstyle error? Then it's ready for merge |
Siedlerchr
added
the
status: ready-for-review
Contributor
Author
|
@Siedlerchr I forgot to remove the unused import. It should pass the style check now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #5555 this PR removes some obsolete notifications and additionally removes notifications during autosave.
I have also removed the strings from the language file, however, I was not sure if this was correct?