Skip to content

Conversation

@Ka0o0
Copy link
Contributor

@Ka0o0 Ka0o0 commented Nov 17, 2019

Hi,
I found a bug where JavaFx was doing some recalculations during the initial layouting.
Setting setResizableWithParent before initial layouting was finished resulted in JavaFx assuming a wrong fixed width.
I changed that by adding the code to a run later block.

It works good for me on Mac. Are there any concerns with that?

Best regards
Kai

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 18, 2019
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the quick fix.

@tobiasdiez tobiasdiez merged commit 9ab537f into JabRef:master Nov 18, 2019
LinusDietz added a commit that referenced this pull request Dec 3, 2019
koppor pushed a commit that referenced this pull request Sep 15, 2021
5facb37 Update soil-biology-and-biochemistry.csl (#5630)
dba7c17 Change representation of locators (#5629)
38c5b99 change et-al settings (#5628)
634b5e0 Create netherlands-journal-of-geosciences.csl (#5624)
fa2cce2 Create journal-of-information-literacy.csl (#5622)
c0d2bf1 Add legislation to AZR & Austrian Legal (#5625)
9724c6e UACJ: Fix op. cit.
b12f90f Update style-manual-australian-government.csl (#5603)
94dba2c Create sports-health.csl (#5620)
2ca5cd8 Update urad-rs-za-makroekonomske-analize-in-razvoj.csl (#5619)
32ef9ba Create annals-of-eye-science.csl (#5615)
928e5a6 Create journal-of-microbiology.csl (#5616)
a829c84 Update harvard-cite-them-right-no-et-al.csl (#5617)
6182c7b Fix the right _St. York_ Harvard style
1454760 Fix York Harvard title
d8c5cef Create harvard-cite-them-right-11.csl (#5612)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 5facb37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants