Remove background command line window #5965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
the
status: ready-for-review
Siedlerchr
approved these changes
Feb 20, 2020
|
I would prefer the log4j issue be fixed and in the meantime I would let stay the console open for error messages |
|
❤️ We already have the help in the UI
I would assume this is enough for users to send issues. Even if this is not the case anymore, the background window will disturb many more users than those reporting issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5474. Apparently, the upstream bug in the jdk concerning cmd line arguments was fixed in the meantime, which makes the
win-consoletoggle obsolete.Only problem I've encountered so far is that no logger output is written to the console. Combined with the Log4j issues we have at the moment, this means that for users it's not possible to report detailed stack traces etc. Workaround: use
.\runtime\bin\JabRefto start JabRef instead ofJabRef.exe(I would add this to the release notes under "known issues").