Name field now in focus whenever 'add subgroup' button selected #6328
Conversation
There was a problem hiding this comment.
Hi @HussainArif12 . Congratulations and thank you very much for you very first contribution to JabRef. We are always happy to welcome new people here.
I have some small comments on your PR. Please fix them and as soon as a second core developer approves, we can merge this into the master branch.
.vscode/tasks.json
Outdated
| "command": "gradle" | ||
| } | ||
| ] | ||
| } No newline at end of file |
There was a problem hiding this comment.
This seems off-topic for this PR. Please remove the file tasks.json in the PR.
|
|
||
| // Basic Settings | ||
| @FXML private TextField nameField; | ||
| @FXML private TextField nameField; |
There was a problem hiding this comment.
Identation is off. Please restore.
In IntelliJ you have a command to autoformat code according to our standards, by selecting the code and pressing Ctrl + Alt + L. I don't know if vscode does have this option too. Maybe it's worth a few minutes researching. Saves a lot of time.
About our codingstandards, we use checkstyle to keep our standards coherent. You can install this for vscode here: https://marketplace.visualstudio.com/items?itemName=shengchen.vscode-checkstyle
I did not use checkstyle with vscode, so I'm no help in configuring it, but it should be straightforward with the documentation of the plugin.
|
|
||
| @FXML | ||
| public void initialize() { | ||
| System.out.println("Group Dialog View initiated"); |
There was a problem hiding this comment.
In JabRef, we are using a different kind of infrastructure to log messages:
private static final Logger LOGGER = LoggerFactory.getLogger(xyz.class);
[...]
LOGGER.debug("My debug message", ex);
But writing a debug message for every dialog, which is opened is not required, so this can be omitted.
| hierarchyToolTip.put(GroupHierarchyType.INDEPENDENT, Localization.lang("Independent group: When selected, view only this group's entries")); | ||
|
|
||
| nameField.textProperty().bindBidirectional(viewModel.nameProperty()); | ||
| // nameField.textProperty().bindBidirectional(viewModel.nameProperty()); |
There was a problem hiding this comment.
Disabling the binding of this field to the ViewModel would make the user unable to change the name of a group. Please restore the binding.
| } | ||
| }); | ||
|
|
||
| // nameField.requestFocus(); |
There was a problem hiding this comment.
You can just delete this comment, as you have moved it into the Platform.runLater-block.
|
Also please don't forget to mention your fix in the changelog. |
…es 'Add subgroup'
|
Did you close your PR by accident? |
|
I've closed the commits that had faults in them and then made new commits
to correct them.
…On Mon, Apr 20, 2020, 5:07 PM Carl Christian Snethlage < ***@***.***> wrote:
Did you close your PR by accident?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#6328 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIKA3XE2ZVATS3GIF7G574LRNQ3H5ANCNFSM4MMKERRA>
.
|
f6c778e Update emerald-harvard.csl (#6335) d6c6a16 Fix Brazilian quotes on chicago-author-date.csl (#6317) a1549b6 Update medizinische-hochschule-hannover.csl (#6330) da88073 Update journal-of-the-american-college-of-cardiology.csl (#6334) a520d8e Bump nokogiri from 1.13.9 to 1.13.10 (#6333) ba54b44 Update royal-society-of-chemistry.csl (#6328) 1378ba7 LUSEM: Remove full stop (#6332) 9e3cf89 Create interpreting.csl (#6254) bef74ed Create conservation-science-and-practice.csl (#6258) 9fb7eb7 Bug fixes triangle.csl (#6251) e6112ba Update ucl-university-college-apa.csl (#6250) 6dcba3a Update engineering-technology-and-applied-science-research.csl (#6247) 00fe4a2 Create constructivist-foundations.csl (#6243) 03ad71b Create les-mondes-du-travail.csl (#6234) a2bce86 Corrections based on author instructions (#6306) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: f6c778e
84dba23 Update international-union-of-crystallography.csl (#6279) 13dd9e8 Update zeitschrift-fur-deutsche-philologie.csl (#6340) d95b652 Create cahiers-mondes-anciens.csl (#6203) ded567c Create rassegna-degli-archivi-di-stato-bibliografia-generale.csl (#6275) 124777a Create scientific-online-letters-on-the-atmosphere.csl (#6261) 3c276e7 Create american-medical-association-no-url-alphabetical.csl (#6252) 595ad95 Bump mathieudutour/github-tag-action from 6.0 to 6.1 (#6287) 7008128 Create cambridge-a (#6336) 17e930c Update norsk-apa-manual-note.csl (#6338) b360859 Update norsk-apa-manual.csl (#6337) f6c778e Update emerald-harvard.csl (#6335) d6c6a16 Fix Brazilian quotes on chicago-author-date.csl (#6317) a1549b6 Update medizinische-hochschule-hannover.csl (#6330) da88073 Update journal-of-the-american-college-of-cardiology.csl (#6334) a520d8e Bump nokogiri from 1.13.9 to 1.13.10 (#6333) ba54b44 Update royal-society-of-chemistry.csl (#6328) 1378ba7 LUSEM: Remove full stop (#6332) 9e3cf89 Create interpreting.csl (#6254) bef74ed Create conservation-science-and-practice.csl (#6258) 9fb7eb7 Bug fixes triangle.csl (#6251) e6112ba Update ucl-university-college-apa.csl (#6250) 6dcba3a Update engineering-technology-and-applied-science-research.csl (#6247) 00fe4a2 Create constructivist-foundations.csl (#6243) 03ad71b Create les-mondes-du-travail.csl (#6234) a2bce86 Corrections based on author instructions (#6306) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 84dba23
2 participants
fixes #6307
Name Text field is now in focus whenever the 'add subgroup' button is added