Skip to content

Refactor edit action #6808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 30, 2020
Merged

Refactor edit action #6808

merged 6 commits into from
Aug 30, 2020

Conversation

@Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Aug 28, 2020 •
edited
Loading

Fixes #6293

Needs testing unter linux

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member Author

Siedlerchr commented Aug 30, 2020 •
edited
Loading

DOI pasting still works. tested again.

@koppor koppor added this to the v5.1 milestone Aug 30, 2020
@koppor koppor merged commit 2faa149 into master Aug 30, 2020
@koppor koppor deleted the refactorEditAction branch August 30, 2020 19:52
Siedlerchr added a commit that referenced this pull request Aug 31, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into writebackupToTemp
548fac1 
* upstream/master: (120 commits)
  Follow up fix for copy paste (#6820)
  Add CSS Customisation (#6725)
  Separate signing and notarizing (#6822)
  Remove checkstyle hack. 8.36 got released (#6816)
  Feature/enable lucene query parsing (#6799)
  New release cycle
  Bump WyriHaximus/github-action-wait-for-status from v1.1.2 to v1.2 (#6814)
  Bump mockito-core from 3.5.5 to 3.5.7 (#6813)
  Bump classgraph from 4.8.87 to 4.8.89 (#6812)
  Bump me.champeau.gradle.jmh from 0.5.0 to 0.5.1 (#6811)
  Bump checkstyle from 8.35 to 8.36 (#6810)
  Improve Changelog
  Refactor edit action (#6808)
  Fixed typo in BuildInfo (#6807)
  disable checkstyle for generated
  fix checkstyle
  Simplify check-links.yaml (markdown-link-check) (#6720)
  Rename /gen to /generate (#6800)
  Disable CSL refresh on push (#6803)
  New Crowdin updates (#6804)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/JabRefFrame.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v5.1

Development

Successfully merging this pull request may close these issues.

Paste button on maintable does not work properly

4 participants

@Siedlerchr @koppor @calixtus