Add IdBasedSearchFetcher to jstor #7145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
reviewed
Nov 30, 2020
src/main/java/org/jabref/logic/importer/fetcher/JstorFetcher.java
Outdated
Show resolved
Hide resolved
tobiasdiez
approved these changes
Nov 30, 2020
Member
tobiasdiez
left a comment
tobiasdiez
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Looks good to me
tobiasdiez
added
the
status: ready-for-review
DominikVoigt
suggested changes
Dec 1, 2020
Contributor
DominikVoigt
left a comment
DominikVoigt
left a comment
There was a problem hiding this comment.
Hey,
Thanks for your contribution!
I only have one question otherwise LGTM!
Comment on lines
+173
to
+176
| @Override | ||
| public void doPostCleanup(BibEntry entry) { | ||
| // do nothing | ||
| } |
Contributor
There was a problem hiding this comment.
Why did you overwrite this?
Contributor
Author
There was a problem hiding this comment.
as both SearchBased and IdBased Fetchers have a doPostCleanup default impl, the compiler is not sure which one to call
DominikVoigt
approved these changes
Dec 1, 2020
Contributor
DominikVoigt
left a comment
DominikVoigt
left a comment
There was a problem hiding this comment.
Thanks for the clarification! :)
Siedlerchr
added a commit
that referenced
this pull request
Dec 5, 2020
* upstream/master: (36 commits) Fix remembering password for sql db (#7154) Update to libre office 7.0.3 (#7150) Add IdBasedSearchFetcher to jstor (#7145) Squashed 'src/main/resources/csl-styles/' changes from 55200d0..a20406d Bump antlr4-runtime from 4.8-1 to 4.9 (#7136) Bump antlr4 from 4.8-1 to 4.9 (#7138) Bump mariadb-java-client from 2.7.0 to 2.7.1 (#7134) Bump classgraph from 4.8.90 to 4.8.92 (#7139) Bump mockito-core from 3.6.0 to 3.6.28 (#7135) Bump gittools/actions from v0.9.6 to v0.9.7 (#7144) Bump checkstyle from 8.37 to 8.38 (#7142) Add missing author Fix document viewer not showing first page (#7132) Add githandler mock to crawler test to fix NPE (#7133) Searchbar glyph icon colors in Dark Theme [FIXED] (#7131) Fix binding issue for the regex and case sensitive search buttons (#7125) Enable automated cross library search using a cross library query lan… (#7124) Add tracking Update Java Version Welcome Dominik ✌ ...
Siedlerchr
added a commit
that referenced
this pull request
Dec 6, 2020
* upstream/master: Improve library loading UX (#7119) remove jython (#7157) Add missing authors Remove obsolete hint Fixed issue in PreviewView for number textfield (#7158) Fix for issue 6959 (#7151) Revert "remove jython (#7155)" (#7156) remove jython (#7155) Fix remembering password for sql db (#7154) Update to libre office 7.0.3 (#7150) Add IdBasedSearchFetcher to jstor (#7145) Squashed 'src/main/resources/csl-styles/' changes from 55200d0..a20406d Bump antlr4-runtime from 4.8-1 to 4.9 (#7136)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #6627 (comment)