Skip to content

Only use Grobid when enabled #8042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2021
Merged

Only use Grobid when enabled #8042

merged 1 commit into from
Aug 31, 2021

Conversation

@btut
Copy link
Contributor

@btut btut commented Aug 31, 2021 •
edited
Loading

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr merged commit 7516e3f into JabRef:observable-prefs Aug 31, 2021
koppor pushed a commit that referenced this pull request Sep 1, 2021
@calixtus @tobiasdiez @btut
Observable preferences B (ProtectedTerms, EntryEditor and MrDlib) (#8046
705d4b1 
)

* Proposal using obserables

* Added some flesh to poc

* Refactored ImporterPreferences to new preferences logic and fixed some ide suggestions

* Update EntryEditor.java

* Only use Grobid when enabled (#8042)

* Refactored ProtectedTermsPreferences to observable prefs

* Fixed ProtectedTermsTab

* Reworked context menu and improved visuals of ProtectedTermsTab

* Fixed merge error

* Refactored MrDlibPreferences to prefrences observables

* Refactored EntryEditorpreferences to observable preferences

* Fixed error and remark, made some small visual improvements on ProtectedTermsTab

Co-authored-by: Tobias Diez <[email protected]>
Co-authored-by: Benedikt Tutzer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@btut @Siedlerchr @calixtus