Skip to content

Fix icon picker excpetion in groups dialog #8290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Fix icon picker excpetion in groups dialog #8290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b54e8c8
Fix icon picker excpetion in groups dialog
Siedlerchr Dec 1, 2021
e9538c9
fcking checkstyle
Siedlerchr Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/main/java/org/jabref/gui/groups/GroupDialogView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,24 +231,30 @@ private void openIconPicker() {
ikonGridView.setPrefHeight(400);
ikonGridView.setHorizontalCellSpacing(4);
ikonGridView.setVerticalCellSpacing(4);
ikonGridView.setItems(filteredList);

VBox vBox = new VBox(10, searchBox, ikonGridView);
vBox.setPadding(new Insets(10));

// Necessary because of a bug in controlsfx GridView
// https://github.com/controlsfx/controlsfx/issues/1400
Platform.runLater(() -> {
ikonGridView.setItems(filteredList);
});

PopOver popOver = new PopOver(vBox);
popOver.setDetachable(false);
popOver.setArrowSize(0);
popOver.setCornerRadius(0);
popOver.setTitle("Icon picker");
popOver.show(iconPickerButton);

}

public class IkonliCell extends GridCell<Ikon> {
@Override
protected void updateItem(Ikon ikon, boolean empty) {
super.updateItem(ikon, empty);
if (empty || ikon == null) {
if (empty || (ikon == null)) {
setText(null);
setGraphic(null);
} else {
Expand Down