Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
### Changed

- We integrated the external file types dialog directly inside the preferences. [#8341](https://github.com/JabRef/jabref/pull/8341)
- We disabled the add group button color change after adding 10 new groups. [#8051](https://github.com/JabRef/jabref/issues/8051)
- We inverted the logic for resolving [BibTeX strings](https://docs.jabref.org/advanced/strings). This helps to keep `#` chars. By default String resolving is only activated for a couple of standard fields. The list of fields can be modified in the preferences. [#7010](https://github.com/JabRef/jabref/issues/7010), [#7102](https://github.com/JabRef/jabref/issues/7012), [#8303](https://github.com/JabRef/jabref/issues/8303)
- We moved the search box in preview preferences closer to the available citation styles list. [#8370](https://github.com/JabRef/jabref/pull/8370)
- Changing the preference to show the preview panel as a separate tab now has effect without restarting JabRef. [#8370](https://github.com/JabRef/jabref/pull/8370)
Expand Down
14 changes: 0 additions & 14 deletions src/main/java/org/jabref/gui/groups/GroupTree.css
Original file line number Diff line number Diff line change
Expand Up @@ -102,20 +102,6 @@
-fx-translate-x: -0.4em;
}

#addNewGroup:active {
-fx-border-width: 0px;
-fx-background-color: -jr-theme;
-fx-padding: 0.5em;
-fx-text-fill: -jr-white;
}

#addNewGroup:inactive {
-fx-border-width: 0px;
-fx-background-color: -jr-icon-background-active;
-fx-padding: 0.5em;
-fx-text-fill:-jr-black;
}

#groupFilterBar {
-fx-background-color: -jr-sidepane-header-background;
-fx-border-color: -jr-separator;
Expand Down
16 changes: 0 additions & 16 deletions src/main/java/org/jabref/gui/groups/GroupTreeView.java
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,6 @@ private void initialize() {
});
searchField.textProperty().addListener((observable, oldValue, newValue) -> searchTask.restart());

setNewGroupButtonStyle(groupTree);

groupTree.rootProperty().bind(
EasyBind.map(viewModel.rootGroupProperty(),
group -> {
Expand Down Expand Up @@ -245,7 +243,6 @@ private void initialize() {
groupTree.setRowFactory(treeTable -> {
TreeTableRow<GroupNodeViewModel> row = new TreeTableRow<>();
row.treeItemProperty().addListener((ov, oldTreeItem, newTreeItem) -> {
setNewGroupButtonStyle(treeTable);
boolean isRoot = newTreeItem == treeTable.getRoot();
row.pseudoClassStateChanged(rootPseudoClass, isRoot);

Expand Down Expand Up @@ -481,19 +478,6 @@ private void setupClearButtonField(CustomTextField customTextField) {
}
}

private void setNewGroupButtonStyle(TreeTableView<GroupNodeViewModel> groupTree) {
PseudoClass active = PseudoClass.getPseudoClass("active");
PseudoClass inactive = PseudoClass.getPseudoClass("inactive");

if (groupTree.getRoot() != null) {
boolean isActive = groupTree.getExpandedItemCount() <= 10;
addNewGroup.pseudoClassStateChanged(active, isActive);
addNewGroup.pseudoClassStateChanged(inactive, !isActive);
} else {
addNewGroup.pseudoClassStateChanged(active, true);
}
}

private static class DragExpansionHandler {
private static final long DRAG_TIME_BEFORE_EXPANDING_MS = 1000;
private TreeItem<GroupNodeViewModel> draggedItem;
Expand Down