Skip to content

Conversation

@koppor
Copy link
Member

@koppor koppor commented Apr 18, 2022

Since my last checkstyle PR #6283 new versions of checkstyle have been released. I went through the changelog (https://checkstyle.sourceforge.io/releasenotes.html) and added new interesting rules. Here the result.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added dev: code-quality Issues related to code or architecture decisions status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Apr 18, 2022
@Siedlerchr Siedlerchr merged commit a022324 into main Apr 19, 2022
@Siedlerchr Siedlerchr deleted the refine-checkstyle branch April 19, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: code-quality Issues related to code or architecture decisions status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants