Fix customized entry problem #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r modify its content Fix typo in BibtexEntryWriter and rename methods writeSorted/writeUnsorted to writeNewStyle/writeOldStyle
…ryType instead of a reference to the original object in the global TreeMap This should fix (at least partially) https://sourceforge.net/p/jabref/bugs/1221/ (and duplicates)
Prevent other warnings
Member
|
Looks good from a first sight. Two minor things: missing CHANGELOD entry and tabs instead of spaces (maybe IDE |
Contributor
Author
|
Thanks, I will take care of my formatter settings for future commits. Concerning the CHANGELOG, do you generally also include bugfixes in it? If not, this PR does not contain any new feature. |
Contributor
|
Yes, please include bugfixes as well. |
…ename to GuiTestUtils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains, besides more or less minor code cleanup and refactoring, a bugfix for the problem with customized entry types (commit e92238a). See https://sourceforge.net/p/jabref/bugs/1221/ (with many duplicates)