Skip to content

Conversation

@koppor
Copy link
Member

@koppor koppor commented Jan 4, 2023

We set the new major version to 6 directly after the last release (e586da3). However, we decided to release version 5.9 inbetween. Thus, we need to rool back.

Possibilities:

  • Open a separate branch, cherry-pick all commits but leave out the semver commit. -- I tried with git rebase -i v5.8, but that was not good
  • Manually set the version

This PR implements the second approach. Note that this will NOT re-open #5399 and #5657 (linked from
#5682), because the patch number is increased by using the number of commits since the last (hard-coded) release v5.8.

Resulting about dialog:

grafik

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added this to the v5.9 milestone Jan 4, 2023
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 4, 2023
@koppor koppor requested review from Siedlerchr and calixtus January 5, 2023 14:40
@calixtus calixtus modified the milestones: v5.9, v6.0 Jan 5, 2023
@calixtus
Copy link
Member

calixtus commented Jan 5, 2023

changelog needs to be adapted too

@calixtus calixtus merged commit f31bca9 into main Jan 6, 2023
@calixtus calixtus deleted the prepare-v5.9 branch January 6, 2023 20:19
calixtus added a commit that referenced this pull request Jan 8, 2023
calixtus added a commit that referenced this pull request Jan 8, 2023
@koppor koppor mentioned this pull request Dec 23, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants