[WIP] Implemented about Dialog in Java FX #964
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old dialog and html layout file have been removed. The layout of the dialog panel is defined in the AboutDialogLayout.fxml located in the resources with its stylesheet. The AboutDialogController class takes care of the text initialization of any components in the layout. It also implements any methodes called from any component of the dialog panel.
|
#871 this seems to be related to the about dialog |
boceckts
changed the title
|
Please create your pull requests against the javafx branch instead of master. |
|
As requested see #968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first dialog in JabRef being implemented in JavaFX. The Dialog is highly flexible in positioning and styling its components through a fxml and corresponding css stylesheet. If JavaFX should be a part of JabRef it is probabbly usefull to define a global stylesheet as well to become a consistent look and feel.
To include JavaFX in JabRef I had to adjust the starting and closing behaviour of Jabref.
In order to run these commits, Java 8_40 or newer is required!