rotors driver first prototype #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 27, 2022
iamarkaj
reviewed
Jul 28, 2022
Member
iamarkaj
left a comment
iamarkaj
left a comment
There was a problem hiding this comment.
Please remove the unnecessary comments and spaces. The "firefly" model is missing inside drone_assets.
pariaspe
requested changes
Aug 1, 2022
| return True, 0 | ||
| elif not req and 0.0<=self.current_z<0.3: | ||
| rospy.loginfo("Firefly Disarming") | ||
| self.__is_armed = False |
Collaborator
There was a problem hiding this comment.
Not sure if disarming when I might be flying is a good idea. If I'm landing at 0.2m height I'll be disarmed but flying, right?
Contributor
Author
There was a problem hiding this comment.
solved in latest changes..these were some unresolved contradictions and I've solved with little changes
|
|
||
| self.frame_id = self.current_state.header.frame_id | ||
|
|
||
| if self.current_z<0.1: |
Collaborator
There was a problem hiding this comment.
Not bad, but it can be done better as finite state machine. Called from arming and takeoff/land methods
Contributor
Author
There was a problem hiding this comment.
solved in latest commits
pariaspe
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for interfacing drone wrapper and rotors sim