Use correct parameters for loadAsyncOptions #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for PR#360 / PR#355 (the two combined cause a potential issue) If the cache is disabled, and the value is updated, the new options received from the callback should be used for the display value, not the options from state.options, as the state after the callback is stale (this.setState() has been called, but won't have taken effect due to update batching) Tests added.
JedWatson
added a commit
that referenced
this pull request
Aug 9, 2015
Use correct parameters for loadAsyncOptions
Owner
|
Sweet. This is what we needed to release |
Collaborator
Author
|
Yep :-) On Sun, 9 Aug 2015 06:37 Jed Watson [email protected] wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for PR #360 / #355 (the two combined cause a potential issue)
If the cache is disabled, and the value is updated, the new options received
from the callback should be used for the display value, not the options from
state.options, as the state after the callback is stale (this.setState() has
been called, but won't have taken effect due to update batching)
Tests added.