Skip to content

Conversation

@jwarning
Copy link

This seems to resolve the weird behaviour in IE when clicking options in the drop down list too quickly can cause a single click to add two options. There may be a better solution, but this seems to be the simplest that fixes it without a lot of extra complication.

I'm not sure if the onClick part of the option is necessary if the mouseDown event fires, however there may be a reason it is there?

@JedWatson
Copy link
Owner

@jwarning I think that may be there for mobile device support, we need to look into how touch handles this change before it's safe to merge. I think you've identified the cause of the issue in IE, but I don't want to fix it at the cost of mobile support. Let's make sure the change works for both.

@jwarning
Copy link
Author

@JedWatson Yeah that would have been my guess, so that sounds like a good idea to do first.

@jwarning
Copy link
Author

I have checked this change on a Samsung Galaxy tablet through Chrome and it seems fine. That being said I did notice that the clear buttons on all the inputs (the cross) either doesn't work or is really hard to tap properly.

@jwarning
Copy link
Author

jwarning commented Sep 9, 2015

@JedWatson After a bit of further investigation, including on iPads, this seems to work fine as only the mouseDown event seems to matter. This PR: #39 seems to have introduced the issue and even though the mousedown and onclick weren't causing it to fire more than once on most browsers, IE (11) seems to suffer from this issue. That being said I'm unsure whether there was another motivation for using onClick originally?

@agirton
Copy link
Collaborator

agirton commented Jun 9, 2017

Haven't seen this issue yet for the latest release. Closing as this PR is for an old version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants