Fixes an issue if options are updated #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 23, 2015 12:14
If the props.value was set, but then options were set later (in componentWillReceiveProps), the selected value (props.value) would not be selected from the new options.
|
👍, currently having this problem and this fix would be great! |
|
Can you please rebase and only change the source files? Cheers :) |
|
This is now fixed in a newer and better commit :) |
bkoltai
pushed a commit
to bkoltai/react-select
that referenced
this pull request
Sep 20, 2017
Update to JedWatson/react-select v1.0.0-rc.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the props.value was set, but then options were set later (in
componentWillReceiveProps), the selected value (props.value) would not
be selected from the new options.