Skip to content

Conversation

danil-pavlov
Copy link
Contributor

No description provided.

Copy link
Collaborator

@koshachy koshachy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 525 lines in js-react.md
Will return later.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 22, 2022
@koshachy koshachy removed the Stale label Jan 22, 2022
@github-actions
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 22, 2022
@p7nov p7nov removed the Stale label Feb 22, 2022
@AlexanderPrendota
Copy link
Collaborator

Bad samples
Snippets:
File: docs/topics/js/js-react.md

import react.dom.*
import kotlinx.browser.document
import kotlinx.css.*
import kotlinx.serialization.Serializable
import styled.*

//sampleStart
fun main() {
   render(document.getElementById("root")) {
      h1 {
         +"Hello, React+Kotlin/JS!"
      }
   }
}
//sampleEnd

(0:7, 0:12) ERROR Unresolved reference: react
(1:15, 1:22) ERROR Unresolved reference: browser
(2:15, 2:18) ERROR Unresolved reference: css
(3:15, 3:28) ERROR Unresolved reference: serialization
(4:7, 4:13) ERROR Unresolved reference: styled
(8:3, 8:9) ERROR Unresolved reference: render
(8:10, 8:18) ERROR Unresolved reference: document
(9:6, 9:8) ERROR Unresolved reference: h1
(10:9, 10:10) ERROR Unresolved reference: +


@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 2, 2022
@koshachy koshachy removed the Stale label Apr 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 4, 2022
@koshachy koshachy removed the Stale label May 10, 2022
@github-actions
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Copy link
Member

@SebastianAigner SebastianAigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvements here and there still possible, overall looking good!

Copy link
Member

@SebastianAigner SebastianAigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying all my feedback! Only some very minor points left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants