[SPARKNLP-906] Fix reading suffix #13945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maziyarpanahi
changed the base branch from
master
to
release/511-release-candidate
maziyarpanahi
approved these changes
Sep 7, 2023
maziyarpanahi
added a commit
that referenced
this pull request
Sep 11, 2023
…date * [SPARKNLP-906] Fix reading suffix (#13945) * Sparknlp 888 Add ONNX support to MPNet embeddings (#13955) * adding onxx support to mpnet * remove name in test * updating default name for mpnet models in scala and python * updating default model name * Adding ONNX Support to ALBERT Token and Sequence Classification and Question Answering annotators (#13956) * SPARKNLP-891 Adding ONNX support for AlbertQuestionAnswering SPARKNLP-892 Adding ONNX support for AlbertSequenceClassification SPARKNLP-893 Adding ONNX support for AlbertTokenClassification * SPARKNLP-891 Adding ONNX support for AlbertQuestionAnswering SPARKNLP-892 Adding ONNX support for AlbertSequenceClassification SPARKNLP-893 Adding ONNX support for AlbertTokenClassification * SPARKNLP-884 Enabling getVectors method to get word vectors as spark dataframe (#13957) * [SPARKNLP-890] ONNX E5 MPnet example (#13958) * Bump version to 5.1.1 * [SPARKNLP-891] [SPARKNLP-892] [SPARKNLP-893] Adding docs for ONNX support in AlbertXXX * Fix misspelling [skip test] * Fixing onnx saving path bug (#13959) * fixing onnx write issue on windows * fixing indentation * fixing formatting * fixing formatting * final formatting fix * Fix onnx saving bug --------- Co-authored-by: Devin Ha <[email protected]> Co-authored-by: Maziyar Panahi <[email protected]> --------- Co-authored-by: Devin Ha <[email protected]> Co-authored-by: ahmedlone127 <[email protected]> Co-authored-by: Danilo Burbano <[email protected]> Co-authored-by: Danilo Burbano <[email protected]> Co-authored-by: Devin Ha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the loading onnx whisper models. Previously, a suffix was used to name the model files. This has been removed.
How Has This Been Tested?
All Tests passing.
Screenshots (if appropriate):
Types of changes