Skip to content

Conversation

@DevinTDHa
Copy link
Member

Description

This PR fixes a bug with the DocumentCharacterTextSplitter, where it couldn't be saved in a pipeline (saving it individually worked fined).

This was due to the companion object missing for the annotator.

How Has This Been Tested?

New and old tests passing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DevinTDHa DevinTDHa self-assigned this Dec 9, 2023
@maziyarpanahi maziyarpanahi changed the base branch from master to release/521-release-candidate December 27, 2023 14:12
@maziyarpanahi maziyarpanahi merged commit dc18ef4 into JohnSnowLabs:release/521-release-candidate Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants