Skip to content

Conversation

@ahmedlone127
Copy link
Contributor

@ahmedlone127 ahmedlone127 commented Jan 31, 2024

Description

Refactors code and adds logging to handle exceptions in XXXForClassification models to fix sbt-warnings when

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@maziyarpanahi maziyarpanahi changed the base branch from master to release/530-release-candidate February 19, 2024 15:10
@maziyarpanahi maziyarpanahi merged commit 5067417 into release/530-release-candidate Feb 19, 2024
@coveralls
Copy link

coveralls commented Feb 19, 2024

Pull Request Test Coverage Report for Build 7961647790

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 202 unchanged lines in 34 files lost coverage.
  • Overall coverage increased (+0.2%) to 62.872%

Files with Coverage Reduction New Missed Lines %
src/main/scala/com/johnsnowlabs/nlp/annotators/cv/util/io/ImageIOUtils.scala 1 51.35%
src/main/scala/com/johnsnowlabs/nlp/annotators/DateMatcher.scala 1 96.26%
src/main/scala/com/johnsnowlabs/nlp/annotators/DateMatcherUtils.scala 1 87.96%
src/main/scala/com/johnsnowlabs/nlp/annotators/er/EntityRulerModel.scala 1 90.4%
src/main/scala/com/johnsnowlabs/nlp/annotators/MultiDateMatcher.scala 1 99.04%
src/main/scala/com/johnsnowlabs/nlp/annotators/ner/dl/LoadsContrib.scala 1 11.54%
src/main/scala/com/johnsnowlabs/nlp/annotators/ner/dl/NerDLModel.scala 1 58.23%
src/main/scala/com/johnsnowlabs/nlp/annotators/parser/dep/GreedyTransition/DependencyMaker.scala 1 81.01%
src/main/scala/com/johnsnowlabs/nlp/annotators/parser/dep/Tagger.scala 1 47.54%
src/main/scala/com/johnsnowlabs/nlp/annotators/pos/perceptron/PerceptronApproachDistributed.scala 1 82.89%
Totals Coverage Status
Change from base Build 7961349403: 0.2%
Covered Lines: 8958
Relevant Lines: 14248

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants