Skip to content

Fixing colab notebook bugs #14249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 24, 2024
Merged

Fixing colab notebook bugs #14249

merged 4 commits into from
May 24, 2024

Conversation

@ahmedlone127
Copy link
Contributor

@ahmedlone127 ahmedlone127 commented May 16, 2024 •
edited
Loading

This PR fixes all bugs mentioned in #14238
the following notebooks have not been tested/updated:

  • Fine_Tuned_Sentence_Bert_in_Spark_NLP.ipynb ( Not enough RAM to run on colab )
  • HuggingFace in Spark NLP - SwinForImageClassification.ipynb ( updating tensorflow version produces division by 0 error )
  • Fixed bug in XLMRobertaForXXX annotator causing missing spp file ( this closes the following jira issue )
  • updated tensorflow signature in Xlnet embeddings source code to account for custom inputs while being backwards compaitable.

@maziyarpanahi maziyarpanahi changed the base branch from master to release/540-release-candidate May 16, 2024 08:39
@maziyarpanahi maziyarpanahi merged commit 9430402 into release/540-release-candidate May 24, 2024
@maziyarpanahi maziyarpanahi mentioned this pull request May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@maziyarpanahi maziyarpanahi

@ahmedlone127 ahmedlone127

Labels

bug-fix enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahmedlone127 @maziyarpanahi