Skip to content

Added custom stop token id support #14344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2024
Merged

Added custom stop token id support #14344

merged 1 commit into from
Jul 14, 2024

Conversation

@prabod
Copy link
Contributor

@prabod prabod commented Jul 12, 2024

Description

This PR adds the ability to specify custom stop token ids.

Types of changes

  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@prabod prabod requested a review from maziyarpanahi July 12, 2024 10:57
@prabod prabod self-assigned this Jul 12, 2024
@maziyarpanahi maziyarpanahi changed the base branch from master to release/541-release-candidate July 14, 2024 15:00
@maziyarpanahi maziyarpanahi merged commit 257fd57 into release/541-release-candidate Jul 14, 2024
@maziyarpanahi maziyarpanahi mentioned this pull request Jul 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maziyarpanahi maziyarpanahi maziyarpanahi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@prabod prabod

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prabod @maziyarpanahi