2022-01-19-distilbert_token_classifier_typo_detector_en #6796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josejuanmartinez
suggested changes
Jan 19, 2022
Contributor
josejuanmartinez
left a comment
josejuanmartinez
left a comment
There was a problem hiding this comment.
There are a couple of typos in the python/scala code. Can you check?
| .setInputCols(["sentence"])\ | ||
| .setOutputCol("token") | ||
|
|
||
| tokenClassifier = DistilBertForTokenClassification.pretrained("distilbert_token_classifier_typo_detector", "en"))\ |
Contributor
There was a problem hiding this comment.
There are 2 parenthesis, one only needed.
| .setInputCols(Array("sentence")) | ||
| .setOutputCol("token") | ||
|
|
||
| val tokenClassifier = DistilBertForTokenClassification.pretrained("distilbert_token_classifier_typo_detector", "en"))\ |
Contributor
There was a problem hiding this comment.
Two parenthesis, only one needed. And remove also \ in Scala is not needed as you correctly told me some time ago :)
josejuanmartinez
approved these changes
Jan 26, 2022
Contributor
josejuanmartinez
left a comment
josejuanmartinez
left a comment
There was a problem hiding this comment.
Looks good, thank you!
maziyarpanahi
deleted the
2022-01-19-distilbert_token_classifier_typo_detector_en_R3bxMclvDvFZk9qwulf4Kq6r
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.