-
Notifications
You must be signed in to change notification settings - Fork 736
Feature/regex tok trim #6806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
maziyarpanahi
merged 8 commits into
release/341-release-candidate
from
feature/regex-tok-trim
Jan 25, 2022
Merged
Feature/regex tok trim #6806
maziyarpanahi
merged 8 commits into
release/341-release-candidate
from
feature/regex-tok-trim
Jan 25, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abs/spark-nlp into feature/regex-tok-trim
maziyarpanahi
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This RegexTokenizer extension proposes the capability of trimming idenitfied tokens so that they can be used in further processing without having to apply others data transformations.
In particular we can trim tokens and decide whether preserve orignal indexes.
Motivation and Context
It has been noticed that RegexTokenizer was missing the token trimming capability.
How Has This Been Tested?
Full non regression test in Scala with added use cases in specific tests suite.
Added tests on Python interface.
Screenshots (if appropriate):
[info] Suites: completed 131, aborted 0
[info] Tests: succeeded 638, failed 0, canceled 0, ignored 5, pending 0
[info] All tests passed.
Types of changes
Checklist: