-
Notifications
You must be signed in to change notification settings - Fork 87
Abhishek/server side cost calculation #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Mandolaro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a substantial architectural refactoring aimed at enhancing the server-side cost calculation and LLM tracing framework. By modularizing the integration logic for various LLM providers into separate, dedicated sub-packages, the system gains improved maintainability and scalability. The changes also introduce more detailed token usage metrics, particularly for caching, which will enable a more precise understanding of resource consumption and cost implications. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant and well-structured refactoring to move LLM cost calculation to the server side. The client-side logic is now modularized into provider-specific wrappers, which greatly improves maintainability. The changes correctly focus on sending token usage data to the backend instead of calculating costs on the client.
I've identified a few issues:
- A critical issue where an e2e test will fail due to the removal of a cost-related attribute key.
- A high-severity issue regarding duplicated code in the new
llm
module structure. - A high-severity regression where cached token tracking for OpenAI has been lost.
- A medium-severity issue regarding a removed type hint.
Overall, this is a great refactoring. Addressing these points will make it even better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets see it in staging
π Summary
β Checklist