Justin/trace autocreate project #574
Conversation
Summary of ChangesHello @justinsheu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant quality-of-life improvement by enabling the tracer to automatically create a project if it cannot be resolved during initialization. This change eliminates the need for manual project creation in advance, preventing potential errors and ensuring a smoother setup and operation for users, ultimately enhancing the reliability of Judgment export. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a helpful feature to automatically create a project if it doesn't exist during tracer initialization, which improves the user experience by removing a manual setup step. The overall logic is sound. I've added a couple of comments for minor improvements regarding a docstring and error handling.
src/judgeval/tracer/__init__.py
Outdated
| except Exception as e: | ||
| judgeval_logger.error( | ||
| f"Failed to create project with name {project_name}: {e} ... Skipping Judgment export." | ||
| ) | ||
| return None |
There was a problem hiding this comment.
Catching a generic Exception is risky as it can hide unexpected errors (like KeyboardInterrupt or SystemExit) and make debugging more difficult. It's better to catch only the specific exceptions you anticipate from the API call, such as JudgmentAPIError for API-related issues and httpx.RequestError for network problems. This will make the error handling more robust. Note that you'll need to import these exception types.
There was a problem hiding this comment.
Do we have a good idea of what possible errors there would be? Is it mainly JudgmentAPIError and httpx.RequestError?
I'm trying to think in my head how annoying catching all exceptions would be, in the KeyboardInterrupt and SystemExit cases
src/judgeval/tracer/__init__.py
Outdated
| def _create_project( | ||
| project_name: str, api_key: str, organization_id: str | ||
| ) -> str | None: | ||
| """Resolve project_id from project_name using the API.""" |
There was a problem hiding this comment.
This docstring appears to be copied from _resolve_project_id and is incorrect. It should be updated to reflect that this method's purpose is to create a new project.
| """Resolve project_id from project_name using the API.""" | |
| """Create a new project with the given name.""" |
src/judgeval/tracer/__init__.py
Outdated
| except Exception as e: | ||
| judgeval_logger.error( | ||
| f"Failed to create project with name {project_name}: {e} ... Skipping Judgment export." | ||
| ) | ||
| return None |
There was a problem hiding this comment.
Do we have a good idea of what possible errors there would be? Is it mainly JudgmentAPIError and httpx.RequestError?
I'm trying to think in my head how annoying catching all exceptions would be, in the KeyboardInterrupt and SystemExit cases
This reverts commit f0875a3.
2 participants
📝 Summary
✅ Checklist