lower to standard broadcast for PseudoBlockArray #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
==========================================
- Coverage 92.00% 91.82% -0.19%
==========================================
Files 14 14
Lines 1264 1272 +8
==========================================
+ Hits 1163 1168 +5
- Misses 101 104 +3
Continue to review full report at Codecov.
|
dlfivefifty
pushed a commit
that referenced
this pull request
Sep 4, 2025
Fixes #295. That issue seemed to be caused by code in the generic block broadcasting logic such as https://github.com/JuliaArrays/BlockArrays.jl/blob/90ddfa96fb0ade3da4f67ac285fcb340350c19c6/src/blockbroadcast.jl#L121-L129 assuming the broadcasting expression is already flat. This PR adds a call to `Broadcast.flatten` to explicitly flatten the broadcast expression in the generic block broadcast code. It appears that at some point `BlockedStyle` broadcasting expressions were being flattened in this `Broadcast.instantiate` definition: https://github.com/JuliaArrays/BlockArrays.jl/blob/90ddfa96fb0ade3da4f67ac285fcb340350c19c6/src/blockbroadcast.jl#L199-L202 but that was changed in #193. Reverting that change broke the tests introduced in #193 so I guess it is not safe to do that. I have to admit I'm not sure if this is the best place to call `Broadcast.flatten`, a lot of this broadcasting code is hard to follow. The place I put it in this PR fixes #295, doesn't break other tests, and is hopefully least likely to interfere with custom implementations of block broadcasting in downstream packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.