Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Jul 20, 2023

This adds tests to ensure that operations such as

julia> B = BlockArray(zeros(6,6), 1:3, 1:3);

julia> view(B)
ERROR: BoundsError: attempt to access 3×3-blocked 6×6 BlockMatrix{Float64, Matrix{Matrix{Float64}}, Tuple{BlockedUnitRange{ArrayLayouts.RangeCumsum{Int64, UnitRange{Int64}}}, BlockedUnitRange{ArrayLayouts.RangeCumsum{Int64, UnitRange{Int64}}}}} at index []

throw a BoundsError. This should prevent regressions.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #297 (3bdaf1e) into master (7b83868) will decrease coverage by 4.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
- Coverage   92.29%   87.96%   -4.33%     
==========================================
  Files          16       16              
  Lines        1479     1479              
==========================================
- Hits         1365     1301      -64     
- Misses        114      178      +64     

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jishnub jishnub merged commit e54dd1b into JuliaArrays:master Jul 20, 2023
@jishnub jishnub deleted the emptyviewtests branch July 20, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant