Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Aug 10, 2023

julia> P = PseudoBlockMatrix(reshape([1:6;], 2, 3), [1,1], [1,2])
2×2-blocked 2×3 PseudoBlockMatrix{Int64}:
 13  5
 ───┼──────
 24  6

julia> Array(P) === parent(P)
false

Suggest parent instead of Array. We should define the convert(Array, P::PseudoBlockArray) in a separate PR.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #303 (e91976b) into master (6299bc5) will increase coverage by 92.33%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #303       +/-   ##
===========================================
+ Coverage    0.00%   92.33%   +92.33%     
===========================================
  Files          16       16               
  Lines        1468     1487       +19     
===========================================
+ Hits            0     1373     +1373     
+ Misses       1468      114     -1354     
Files Changed Coverage Δ
src/pseudo_blockarray.jl 86.95% <ø> (+86.95%) ⬆️

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jishnub jishnub merged commit e0c0b18 into JuliaArrays:master Aug 10, 2023
@jishnub jishnub deleted the pseudoblockarraydocs branch August 10, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant