Skip to content

Conversation

@mtfishman
Copy link
Collaborator

Fixes #317.

@dlfivefifty
Copy link
Member

Whilst this is arguably a breaking change, I doubt its used so maybe it can be considered a "bug fix" if the downstream packages don't break

@codecov
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #318 (9b10944) into master (cf7c29c) will increase coverage by 92.47%.
Report is 5 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #318       +/-   ##
===========================================
+ Coverage    0.00%   92.47%   +92.47%     
===========================================
  Files          16       16               
  Lines        1469     1489       +20     
===========================================
+ Hits            0     1377     +1377     
+ Misses       1469      112     -1357     
Files Coverage Δ
src/BlockArrays.jl 100.00% <ø> (+100.00%) ⬆️
src/blockaxis.jl 97.12% <ø> (+97.12%) ⬆️
src/blockbroadcast.jl 92.74% <ø> (+92.74%) ⬆️
src/blockindices.jl 83.50% <100.00%> (+83.50%) ⬆️

... and 12 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@mtfishman
Copy link
Collaborator Author

Ready to merge?

@dlfivefifty dlfivefifty merged commit 3d8f17e into JuliaArrays:master Dec 1, 2023
@mtfishman mtfishman deleted the tuple_convert branch December 1, 2023 17:18
@mtfishman
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conversion of Block to Tuple

2 participants