Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Mar 28, 2024

The following errors on master, but works after this PR:

julia> BlockArray(reshape(1:6, 2, 3), [1,1], [1,1,1])
2×3-blocked 2×3 BlockMatrix{Int64}:
 135
 ───┼─────┼───
 246

The container is allocated after computing the blocks, and not before it. This lets us obtain the type implicitly from the blocks.

@codecov
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (ea33af1) to head (1cf0d79).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   92.66%   94.47%   +1.80%     
==========================================
  Files          16       16              
  Lines        1499     1501       +2     
==========================================
+ Hits         1389     1418      +29     
+ Misses        110       83      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit d406642 into master Mar 28, 2024
@jishnub jishnub deleted the jishnub/blockarraycreate branch March 28, 2024 16:02
jishnub added a commit that referenced this pull request Apr 7, 2024
* BlockArray construction from immutable array

* Fix test

* Use map instead of broadcasting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants