Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Mar 31, 2024

This seems to have broken LazyBandedMatrices. Although this is the correct approach, let's revert this for now until that package is fixed.

@codecov
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.52%. Comparing base (66e63c4) to head (caf8121).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files          16       16           
  Lines        1498     1498           
=======================================
  Hits         1416     1416           
  Misses         82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit abea9fa into master Mar 31, 2024
@jishnub jishnub deleted the revert-364-jishnub/dataidsPseudoBlock branch March 31, 2024 06:19
jishnub added a commit that referenced this pull request Apr 7, 2024
* Revert "Define dataids for PseudoBlockArrays (#364)"

This reverts commit d4939b3.

* Test against LazyBandedMatrices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants