Introduce BlockIndices that generalizes BlockIndexRange to non-contiguous slicing
#483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
==========================================
+ Coverage 94.05% 94.46% +0.40%
==========================================
Files 19 19
Lines 1765 1769 +4
==========================================
+ Hits 1660 1671 +11
+ Misses 105 98 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dlfivefifty
pushed a commit
that referenced
this pull request
Oct 30, 2025
The current definition of `size(iter::BlockIndices)` was assuming the indices were ranges (resulting from #483 where `BlockIndexRange` was generalized to `BlockIndices` but the definition if `size` wasn't updated accordingly), so for (non-contiguous) non-ranges it was giving the wrong result, this PR fixes that. Additionally, previously only `size` was defined which meant that BlockIndices where the indices had non-trivial axes (like blocked axes) lost information, which is now fixed and tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
BlockIndicesthat generalizesBlockIndexRangeto non-contiguous slicing, such asA[Block(2)[[1, 3]]].BlockIndexRangeis now a type alias forBlockIndiceswhen the indices are unit ranges. Closes #419. Split off from #462.