Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Dec 5, 2023

On master

julia> S = SMatrix{2,3}(1:6)
2×3 SMatrix{2, 3, Int64, 6} with indices SOneTo(2)×SOneTo(3):
 1  3  5
 2  4  6

julia> Z = Zeros(typeof(S), 2,2)
2×2 Zeros{SMatrix{2, 3, Int64, 6}}

julia> Z' # element type is incorrect, as adjoint should be recursive
2×2 Zeros{SMatrix{2, 3, Int64, 6}}

After this,

julia> Z'
2×2 Zeros{SMatrix{3, 2, Int64, 6}}

@codecov
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c3d030) 95.25% compared to head (1b18abd) 99.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage   95.25%   99.89%   +4.63%     
==========================================
  Files           8        8              
  Lines         906      910       +4     
==========================================
+ Hits          863      909      +46     
+ Misses         43        1      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty dlfivefifty merged commit cf8c78d into JuliaArrays:master Dec 5, 2023
@jishnub jishnub deleted the adjtransrecursive branch December 12, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants