Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Jan 17, 2024

On master,

julia> [1,2]' * Zeros(2,2)
1×2 Zeros{Float64}

After this PR,

julia> [1,2]' * Zeros(2,2)
1×2 adjoint(::Zeros{Float64, 1, Tuple{Base.OneTo{Int64}}}) with eltype Float64:
       

This matches the behavior of zeros

@codecov
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (4c50186) to head (d6ce6e5).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #341   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files           8        8           
  Lines        1043     1058   +15     
=======================================
+ Hits         1042     1057   +15     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub added the bugfix label Jan 17, 2024
@jishnub jishnub requested a review from dlfivefifty April 21, 2024 11:25
@jishnub jishnub force-pushed the jishnub/muladjtrans branch from 39dd9da to d6ce6e5 Compare April 25, 2024 13:04
@jishnub jishnub merged commit 545fa12 into master Apr 25, 2024
@jishnub jishnub deleted the jishnub/muladjtrans branch April 25, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants