Skip to content

Remove single-argument map tests on nightly #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Remove single-argument map tests on nightly #358

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6057ba
Remove single-argument map tests on nightly
jishnub Apr 8, 2024
5d68950
Add comment on method removal
jishnub Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,8 +1132,13 @@ end
@test_throws DimensionMismatch map(+, x2', x2)

# Issue https://github.com/JuliaArrays/FillArrays.jl/issues/179
@test map(() -> "ok") == "ok" # was MethodError: reducing over an empty collection is not allowed
@test mapreduce(() -> "ok", *) == "ok"
if VERSION < v"1.11.0-" # In 1.11, 1-arg map & mapreduce was removed
@test map(() -> "ok") == "ok" # was MethodError: reducing over an empty collection is not allowed
@test mapreduce(() -> "ok", *) == "ok"
else
@test_throws "no method matching map" map(() -> "ok")
@test_throws "no method matching map" mapreduce(() -> "ok", *)
end
end

@testset "mapreduce" begin
Expand Down