Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Aug 15, 2024

Currently,

julia> dot(1:2, Eye(2), 1:2)
5

This ignores the element type of Eye. After this PR,

julia> dot(1:2, Eye(2), 1:2)
5.0

@codecov
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (4bfbeec) to head (79dec9e).
Report is 22 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   99.90%   99.91%           
=======================================
  Files           8        8           
  Lines        1086     1118   +32     
=======================================
+ Hits         1085     1117   +32     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub requested a review from dlfivefifty August 19, 2024 08:10
@jishnub jishnub added the bugfix label Aug 22, 2024
@dlfivefifty dlfivefifty merged commit 00492dd into master Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants