Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Aug 21, 2024

Fixes the following discrepancies, accounting for the fact that issymmetric returns true for an empty matrix, and that it acts recursively:

julia> F = Fill([1 2; 3 4], 2, 2);

julia> issymmetric(F)
true

julia> issymmetric(Array(F))
false

julia> F = Fill(im, 0, 0);

julia> ishermitian(F)
false

julia> ishermitian(Array(F))
true

@jishnub jishnub added the bugfix label Aug 21, 2024
@codecov
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (9868632) to head (2f56940).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files           8        8           
  Lines        1110     1110           
=======================================
  Hits         1109     1109           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub requested a review from dlfivefifty August 22, 2024 06:48
@dlfivefifty dlfivefifty merged commit 7b64042 into master Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants